Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 이메일 인증번호 발송 API 구현 #17

Merged
merged 7 commits into from
Oct 28, 2023
Merged

[Feature] 이메일 인증번호 발송 API 구현 #17

merged 7 commits into from
Oct 28, 2023

Conversation

kyeong-hyeok
Copy link
Member

💡 연관된 이슈

close #16

📝 작업 내용

이메일 인증번호 발송 API 구현

  • mail, thymeleaf 의존성 추가
  • thymeleaf mail.html 템플릿 생성
  • Security url 수정
  • EmailService 및 Controller, Dto 생성

💬 리뷰 요구 사항

mail.html을 만들었는데 다음과 같이 인증 번호가 전송됩니다! 조금 더 예쁘게 바꾸고 싶긴 한데!
css 추가하면 되려나 안드로이드 호정님?!

image

@kyeong-hyeok kyeong-hyeok added ✨ Feature 기능 개발 Priority: Medium 우선순위 중간 🐯 Koeyhk 담당자 labels Oct 28, 2023
@kyeong-hyeok kyeong-hyeok linked an issue Oct 28, 2023 that may be closed by this pull request
[Feature] 이메일 인증번호 발송 API 구현 #16
Closed
4 tasks
hojeong2747
hojeong2747 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@hojeong2747 hojeong2747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메일 관련 코드들 완전 깔끔한데요! 메일 양식도 깔끔하고 딱 좋다고 생각해요 ㅎㅎ (시간 나면 css 도전해 볼게요 😊)

src/main/java/com/pawwithu/connectdog/error/ErrorCode.java Outdated
@@ -7,6 +7,8 @@
@RequiredArgsConstructor
public enum ErrorCode {

EMAIL_SEND_ERROR("S1", "이메일 인증 코드 전송을 실패했습니다."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜 S인가요! 'SEND' 인가?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-up이라 S로 했는데! 다른 걸로 할까요??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아항
아뇨 회원가입 때 쓰이는 거니까 좋네요!_!

Copy link
Member

@hojeong2747 hojeong2747 Oct 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이후 같의 논의한 건 기록입니당

  • 에러코드가 여러 도메인에 종속될 수 있기 때문에 에러코드명을 도메인을 따라갈지, 에러 내용을 따라갈지 고민 -> 후자로 결정 (ex. 인증 관련이면 "A1")
  • Validation 처리에서 발생하는 MethodArgumentNotValidException은 "V1"

hojeong2747
hojeong2747 approved these changes Oct 28, 2023
View reviewed changes
src/main/java/com/pawwithu/connectdog/error/ErrorCode.java
@@ -10,6 +10,7 @@ public enum ErrorCode {
ALREADY_EXIST_EMAIL("A1", "이미 존재하는 이메일입니다."),
ALREADY_EXIST_NICKNAME("A2", "이미 존재하는 사용자 닉네임입니다."),
ALREADY_LOGOUT_MEMBER("A3", "이미 로그아웃한 회원입니다"),
EMAIL_SEND_ERROR("A4", "이메일 인증 코드 전송을 실패했습니다."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth 관련 묶어서 사용하기로 결정했군! 좋습니다 :)

@kyeong-hyeok kyeong-hyeok merged commit 379c5dc into develop Oct 28, 2023
1 check passed
@kyeong-hyeok kyeong-hyeok deleted the feat/16-email-confirm-api branch October 28, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hojeong2747 hojeong2747 hojeong2747 approved these changes

Assignees
No one assigned
Labels
✨ Feature 기능 개발 🐯 Koeyhk 담당자 Priority: Medium 우선순위 중간
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 이메일 인증번호 발송 API 구현
2 participants
@kyeong-hyeok @hojeong2747